Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(OWNERS): add loresuso to approvers #614

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

loresuso
Copy link
Member

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

I am opening this PR after proposing myself as falcoctl maintainer in today's community call, starting the voting process!
cc @falcosecurity/falcoctl-maintainers

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

OWNERS Outdated Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Jul 24, 2024

/hold until we get a majority vote completed

@leogr
Copy link
Member

leogr commented Jul 24, 2024

ofc big +1 from me! 🤩

Lore, thank you! 🤗

@FedeDP
Copy link
Contributor

FedeDP commented Jul 24, 2024

You surely deserve it! +1 on my side!

Co-authored-by: Leonardo Grasso <[email protected]>
Signed-off-by: Lorenzo Susini <[email protected]>
@alacuku
Copy link
Member

alacuku commented Jul 25, 2024

+1 on my side!

@cpanato
Copy link
Member

cpanato commented Jul 25, 2024

+1

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One week has passed and we also have the majority (4/6).

🥳

/hold cancel

@poiana
Copy link
Contributor

poiana commented Jul 31, 2024

LGTM label has been added.

Git tree hash: 62d4a8583e2b88ae87190710217c414df27efa51

@poiana
Copy link
Contributor

poiana commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 1632a2d into falcosecurity:main Jul 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants